Skip to content

all: port boring changes from pbss #27176 #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AnilChinchawale merged 1 commit into from
Jan 26, 2026
Merged

all: port boring changes from pbss #27176 #1158

AnilChinchawale merged 1 commit into from
Jan 26, 2026

Conversation

@gzliudan
Copy link
Collaborator

@gzliudan gzliudan commented Jun 26, 2025

Proposed changes

Ref: ethereum#27176

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an ✅ in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@gzliudan gzliudan changed the title [WIP] all: port boring changes from pbss #27176 all: port boring changes from pbss #27176 Jan 21, 2026
Copilot AI review requested due to automatic review settings January 21, 2026 07:51
@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ports preparatory changes from ethereum#27176 to support path-based state storage (PBSS). The changes refactor the trie database architecture to introduce a backend interface pattern, separating the hash-based implementation from the core database wrapper.

Changes:

  • Introduces a backend interface pattern for trie databases with a new wrapper layer
  • Moves NodeSet structures from trie package to new trie/trienode package
  • Renames package from trie to hashdb for hash-based database implementation
  • Updates API signatures: adds root and parent parameters to Update method, renames interface methods to be exported

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
trie/trienode/node.go New file containing NodeSet and MergedNodeSet structures moved from trie package
trie/database_wrap.go New database wrapper providing backend abstraction layer for different trie schemes
trie/triedb/hashdb/database.go Package renamed from trie to hashdb, removed preimage handling, updated API signatures
trie/nodeset.go Deleted - functionality moved to trie/trienode package
trie/trie_test.go Updated to use new API with root/parent parameters and trienode package imports
trie/trie.go Updated to use trienode.NodeSet and new Update signature
trie/tracer.go Updated to use exported method names and trienode package
trie/committer.go Updated to use trienode.NodeSet and exported method names
trie/trie_reader.go Updated Reader method name from GetReader
trie/secure_trie.go Updated return type to trienode.NodeSet
core/state/statedb.go Updated to use trienode.NewMergedNodeSet and new Update signature
core/state/state_object.go Updated CommitTrie to return trienode.NodeSet
core/blockchain.go Changed from CommitPreimages to Close for cleanup
XDCx/XDCxlending Updated to use new API signatures with root/parent parameters
internal/ethapi/trie_proof.go Fixed to initialize database for trie
core/rawdb/schema.go Added helper functions for path-based trie node identification

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gzliudan gzliudan force-pushed the port-pbss-changes branch 3 times, most recently from 0ebd656 to 18144d6 Compare January 21, 2026 08:17
Copilot AI reviewed Jan 21, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

core/blockchain_test.go
}
if len(chain.stateCache.TrieDB().Nodes()) > 0 {
if nodes, _ := chain.TrieDB().Size(); nodes > 0 {
t.Fatalf("stale tries still alive after garbase collection")
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spelling "garbase" is incorrect and should be "garbage".

Suggested change
t.Fatalf("stale tries still alive after garbase collection")
t.Fatalf("stale tries still alive after garbage collection")

Copilot uses AI. Check for mistakes.
@rjl493456442 @gzliudan
all: port boring changes from pbss ethereum#27176
b0f8a8b 
* all: port boring changes from pbss

* core, trie: address comments from martin

* trie: minor fixes

* core/rawdb: update comment

* core, eth, tests, trie: address comments

* tests, trie: add extra check when update trie database

* trie/triedb/hashdb: degrade the error to warning
@AnilChinchawale AnilChinchawale merged commit 3d194d4 into XinFinOrg:dev-upgrade Jan 26, 2026
13 checks passed
@gzliudan gzliudan deleted the port-pbss-changes branch January 26, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@AnilChinchawale AnilChinchawale AnilChinchawale approved these changes

@benjamin202410 benjamin202410 benjamin202410 approved these changes

@anunay-xin anunay-xin anunay-xin approved these changes

@liam-lai liam-lai Awaiting requested review from liam-lai

@wanwiset25 wanwiset25 Awaiting requested review from wanwiset25

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gzliudan @AnilChinchawale @benjamin202410 @anunay-xin @rjl493456442